Skip to content

prettier_plugins in config.toml is a no-op #29

Description

@yeskunall

This line is a no-op in your config. It is silently ignored by Zed. crates/language_core/src/language_config.rs has no prettier_plugins field -- the only prettier-related field is prettier_parser_name. Because the struct uses #[derive(Deserialize)] without #[serde(deny_unknown_fields)], unknown keys are silently dropped on parse.

Prettier plugins are only ever loaded from user settings via prettier_plugins_for_language in crates/project/src/prettier_store.rs. There’s no impact to end-users, but it is misleading, and others might read that file and think it’s a supported key, which it is not. Ran into this while I was looking at zed-industries/zed#56994.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions