Skip to content

validate a generated sf symbol after normalizing over the interpolation of the paths - #135

Merged
swhitty merged 1 commit into
swhitty:mainfrom
AF-cgi:feature/validate-variants
Aug 25, 2026
Merged

validate a generated sf symbol after normalizing over the interpolation of the paths#135
swhitty merged 1 commit into
swhitty:mainfrom
AF-cgi:feature/validate-variants

Conversation

@AF-cgi

@AF-cgi AF-cgi commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

I've added a validation for normalized paths. I've figured out that the CLI will generate SF Symbol with not interpolatable SVG's which leads to a runtime crash. With this PR the validator method throws an error. So the user has a better opportunity how they will continue and didn't receive a broken SF Symbol out of the box..

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.88%. Comparing base (a5da29f) to head (7aeaa7d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   88.78%   88.88%   +0.09%     
==========================================
  Files         166      166              
  Lines       13311    13430     +119     
==========================================
+ Hits        11818    11937     +119     
  Misses       1493     1493              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swhitty swhitty left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🙏🏻

@swhitty
swhitty merged commit ed33e03 into swhitty:main Aug 25, 2026
12 checks passed
@AF-cgi
AF-cgi deleted the feature/validate-variants branch August 26, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants