Skip to content

Close out 0003's open items: link #53, decide the release asset - #54

Merged
gavinbee merged 2 commits into
mainfrom
link-53-from-design-0003
Sep 6, 2026
Merged

Close out 0003's open items: link #53, decide the release asset#54
gavinbee merged 2 commits into
mainfrom
link-53-from-design-0003

Conversation

@gavinbee

@gavinbee gavinbee commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

What & why

Tidies 0003's Open items, which came out of #51 carrying two entries that were no longer accurate.

Custom properties → #53. The entry said the idea "needs the property defined at org level first" and left availability as the thing to confirm. Availability is confirmed — the org's endpoints respond, with nothing defined yet:

gh api orgs/swimblocks/properties/schema          # []
gh api repos/swimblocks/.github/properties/values # []
gh api orgs/swimblocks/properties/values          # every repo, "properties": []

So the entry now links the issue and names what that issue actually has to settle: whether swimblocks-reconciler, which is installed org-wide, should hold a Custom properties write permission. AGENTS.md §4 wants an aspirational item pointing at an issue rather than sitting as prose.

Release asset → decided, moved into Design. This was recorded as open but is a no. The tag already addresses the exact file (git show <tag>:.github/settings.yml, or the contents API with ?ref=<tag>), and rollout.yml reads it by checking the tag out, so an asset would be a fourth copy of something reachable three ways. It now sits in Design as a decision, with the condition that would change the answer — something outside git needing the file by URL — and the contrast with swim-club-tech-survey, where the attached CSV is the product people come to the release page for.

That leaves one genuine open item, the rollout failure policy, which is recorded as intended behaviour rather than a question.

Testing

Docs only — no code touched. ruff check . and pytest -q unaffected.

Checklist

  • Linked the issue this PR closes — n/a, no-issue
  • Tests added/updated and passing — n/a, docs only
  • ruff check . clean (Python repos) — n/a, no code changed
  • Docs/README updated if user-facing behaviour changed

NO-ISSUE: design-doc bookkeeping following #51 and #53

🤖 Generated with Claude Code

gavinbee and others added 2 commits September 6, 2026 10:16
The design doc left repository custom properties as prose, with an
availability caveat that has since been answered — the org's property
endpoints respond, nothing is defined yet. Link #53 and say what that issue
actually has to decide, which is the App permission, not availability.

NO-ISSUE: backlink to #53, per AGENTS.md section 4

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CgLE8cg9huy2EZnRoXhmwp
It sat under Open items as undecided, but it isn't: the tag already
addresses the exact file and rollout.yml reads it by checking the tag out,
so an asset would be a fourth copy of something reachable three ways.
State it in Design with the condition that would change the answer.

NO-ISSUE: closes out an open item from 0003 with the decision already taken

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CgLE8cg9huy2EZnRoXhmwp
@gavinbee gavinbee added the no-issue Change small enough to skip the issue-first rule; rationale is in the PR body label Sep 6, 2026
@gavinbee
gavinbee marked this pull request as ready for review September 6, 2026 14:50
@gavinbee
gavinbee merged commit 7e77bd5 into main Sep 6, 2026
1 check passed
@gavinbee
gavinbee deleted the link-53-from-design-0003 branch September 6, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-issue Change small enough to skip the issue-first rule; rationale is in the PR body

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant