Conversation
librowski
force-pushed
the
ds2-button-drop-warning
branch
from
September 14, 2026 07:21
2a27f69 to
b31a27d
Compare
librowski
marked this pull request as ready for review
September 14, 2026 13:14
librowski
requested review from
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
September 14, 2026 13:15
librowski
force-pushed
the
ds2-button-drop-warning
branch
from
September 14, 2026 19:54
b31a27d to
e7ed6fe
Compare
piotrblaszczyk
approved these changes
Sep 15, 2026
Design confirmed the warning button has no practical use in the product: the only occurrences were the import dialog's ignore-and-import action and the warning snackbar action, both of which now render as secondary. The variants, their public custom properties and the docs example entries are removed; the semantic warning role (snackbar surface, node focus ring, execution statuses) is untouched. Migration steps live in the changeset.
librowski
changed the base branch from
ds2-node-text-ellipsis
to
ds2-node-body-spacing
September 15, 2026 08:54
librowski
force-pushed
the
ds2-button-drop-warning
branch
from
September 15, 2026 08:54
e7ed6fe to
8edcc8c
Compare
librowski
added this pull request to stack #151
September 15, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision
Design review (10.09): the warning button has no practical use in the product or in the projects that consume the design system, and the orange text cannot reach the WCAG contrast threshold on any tint or on white. The
warningandghost-warningButton variants are removed. The semanticwarningrole stays where it carries information: Snackbar surface, canvas node focus ring, execution statuses.Change
regular-button/types.ts:BUTTON_VARIANTSloseswarningandghost-warning.variant.module.css: the two variant blocks and the--wb-public-button-warning-*/--wb-public-button-ghost-warning-*custom properties are removed.secondary: the import dialog's "Ignore and import" action (import-modal.tsx) and the warning Snackbar's action button (action-buttons.tsx). Both are cautionary secondary actions next to a primary one;criticalwould overstate them. Open to a different mapping.Release 3.0 already carries major changesets for
@workflowbuilder/ui, so the removal ships in the same major with aBreaking changes:migration note (criticalorsecondary,ghost-criticalorghost-secondary). Changesets: ui major, sdk patch.Verification
ui typecheck, eslint, stylelint, unit tests (button, snackbar),
pnpm -F @workflowbuilder/ui buildincl.check:built-css; sdk and docs typecheck.