fix(supervisor-run): follow Runtime-owned tree roots - #735
Merged
Conversation
Runtime nested begin roots can be ownership paths instead of child ids. Resolve each nested tree through exactly one parent spawn and retain child ids for supervisor identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawned.ownedTreeRootwhen the tree path differs from the child id.Root cause
The reader matched every nested
begin.rootonly againstspawned.id. Runtime records canonical nested roots as ownership paths, so valid child trees appeared to be independent top-level runs.Verification
pnpm exec vitest run src/supervisor-run/runtime-reader.test.ts— 16 passed.pnpm typecheck— passed.pnpm lint— 743 files passed.pnpm build— passed.pnpm verify:package— passed.strict: true: 24 normalized rows, 4 child invocations, 2 nested supervisors, and 2 leaf workers.Local full-suite note
pnpm testcompleted 5,705 of 5,747 tests locally. Thirty-seven unrelated failures come from the macOS/varto/private/varpath alias in temporary-path checks. Two unrelated process-output tests also failed locally. The same base commit passes the full Linux CI workflow: https://github.com/tangle-network/agent-eval/actions/runs/33772469065.