Honor implied end tags for dt and dd - #319
Open
adarshx01 wants to merge 1 commit into
Open
Conversation
Unclosed dt/dd left the parser stack mismatched, so closing a parent dl/body dropped the surrounding tree. Close them the way HTML does: another dt/dd starts, or the parent dl/body/html ends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315
HTML lets
dt/ddomit their end tags. The parser didn't close them when the nextdt/ddstarted or whendl/body/htmlclosed, so the stack didn't match and the leftover-tag cleanup droppedbody/dl.Same implied-end-tag tables already used for
li/p/td.