Conversation
Grommet's boolean `full` prop renders the site inside a fixed-height
`overflow:auto` wrapper (100vw/100vh). The document itself never scrolls,
and since the wrapper has no tabindex it can never receive focus, so
arrow keys, Space, PgUp/PgDn, Home/End cannot scroll any page until
something inside the container happens to be focused. `width: 100vw`
also includes the scrollbar width, causing a phantom horizontal
scrollbar on desktop, and the nested scroll container degrades mobile
address-bar behavior.
Switch to `full="min"` (min-height only, no fixed height, no overflow)
so content flows in the document and scrolls natively, and replace the
outer Box `fill` with `height={{ min: "100vh" }}` so short pages still
push the footer to the bottom of the viewport.
✅ Deploy Preview for tattle-website-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores keyboard scrolling sitewide. Pages could not be scrolled with the keyboard (arrow keys, Space, PgUp/PgDn, Home/End) because the app was rendered inside a fixed-height overflow wrapper instead of the scrolling document.
Changes
fullprop tofull=mininsrc/components/atomic/AppShell.js, so the app no longer renders inside a fixed100vw/100vhoverflow:autowrapper — content flows in the document and scrolls natively.fillprop withheight={{ min: 100vh }}so short pages still push the footer to the bottom of the viewport.width: 100vwincluding scrollbar width, and restores native mobile address-bar scroll behavior.How to Test