Skip to content

test: unit suite and security lint green on macOS; lossless portable type seed #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huyplb merged 2 commits into from
Sep 28, 2026
+17 −8
Merged

test: unit suite and security lint green on macOS; lossless portable type seed #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
210ead9
test: unit suite and security lint green on macOS again
huyplb Sep 27, 2026
4a6ec00
test(seed): make the advanced seed's portable type matrix lossless
huyplb Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ export default tseslint.config(
'**/dist/**',
'**/dist-bin/**',
'**/node_modules/**',
// Agent worktrees are whole checkouts of this repo (gitignored). Linting
// them reports every finding twice, against code that may be days old.
'.claude/**',
],
},

Expand Down
3 changes: 2 additions & 1 deletion eslint.security.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ export default tseslint.config(
// does not run. Dead directives are the main config's job.
{ linterOptions: { reportUnusedDisableDirectives: 'off' } },

{ ignores: ['**/dist/**', '**/dist-bin/**', '**/node_modules/**'] },
// `.claude/**`: agent worktrees are whole checkouts of this repo (gitignored).
{ ignores: ['**/dist/**', '**/dist-bin/**', '**/node_modules/**', '.claude/**'] },

{
files: ['**/*.ts', '**/*.tsx', '**/*.mts', '**/*.mjs'],
Expand Down
4 changes: 2 additions & 2 deletions scripts/seed/advanced/mariadb.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ CREATE TABLE t_all_types (
c_text TEXT,
c_blob BLOB,
c_date DATE,
c_ts DATETIME
c_ts DATETIME(6)
);

-- [B4] Explicit column collation
Expand Down Expand Up @@ -173,7 +173,7 @@ CREATE TABLE t_all_types (
c_varchar VARCHAR(200),
c_text TEXT,
c_date DATE,
c_ts DATETIME,
c_ts DATETIME(6),
c_legacy VARCHAR(20)
);

Expand Down
4 changes: 2 additions & 2 deletions scripts/seed/advanced/mysql.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ CREATE TABLE t_all_types (
c_text TEXT,
c_blob BLOB,
c_date DATE,
c_ts DATETIME
c_ts DATETIME(6)
);

-- [B4] Explicit column collation (demo_d uses general_ci on name_ci)
Expand Down Expand Up @@ -165,7 +165,7 @@ CREATE TABLE t_all_types (
c_varchar VARCHAR(200),
c_text TEXT,
c_date DATE,
c_ts DATETIME,
c_ts DATETIME(6),
c_legacy VARCHAR(20)
);

Expand Down
11 changes: 8 additions & 3 deletions vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { defaultExclude, defineConfig } from 'vitest/config';
import { fileURLToPath } from 'node:url';
import { realpathSync } from 'node:fs';
import { tmpdir } from 'node:os';

const pkg = (p: string) => fileURLToPath(new URL(p, import.meta.url));
Expand Down Expand Up @@ -58,8 +57,14 @@ export default defineConfig({
// Workflow file pipes are confined to FOXFLOW_FILES_DIR. The suites
// build their fixtures under the OS temp dir, so that is the root
// here; the confinement itself is tested with its own roots.
// eslint-disable-next-line security/detect-non-literal-fs-filename -- the OS temp dir
env: { FOXFLOW_FILES_DIR: realpathSync(tmpdir()) },
//
// `tmpdir()` as the suites spell it, not its real path. On macOS it
// is `/var/folders/…`, a symlink to `/private/var/folders/…`; with the
// resolved spelling as the root, every fixture path failed the
// lexical half of the containment check and 41 workflow tests failed
// on every Mac (CI runs Linux, where /tmp is not a link). The real-path
// half resolves both sides itself.
env: { FOXFLOW_FILES_DIR: tmpdir() },
testTimeout: 15_000,
},
},
Expand Down
Loading