Split unit and integration test workflows - #106
Open
jeri-temporal wants to merge 1 commit into
Open
Conversation
Run integration tests in an environment with approval. This permits PRs from forks without automatically granting access to secrets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Run integration tests in an environment, requiring approval from a maintainer
Why?
This permits PRs from forks without automatically granting access to secrets
Testing
Set up a similar environment in my fork, and verified that a PR ran both sets of tests, but required approval before running the integration tests. Verified that same behavior here.
Do note that since this splits/renames workflows, it shows as still waiting for the old workflow names. If we want to merge this, we'll need to update the ruleset