helm: fail CI when values.yaml changes without a schema update - #561
Open
kriyanshii wants to merge 5 commits into
Open
helm: fail CI when values.yaml changes without a schema update#561kriyanshii wants to merge 5 commits into
kriyanshii wants to merge 5 commits into
Conversation
Catch PRs that change Helm values but forget values.schema.json, as the first step of temporalio#536. Co-authored-by: Cursor <cursoragent@cursor.com>
kriyanshii
requested review from
a team,
eniko-dif and
jlegrone
as code owners
August 31, 2026 18:59
Collaborator
|
@kriyanshii awesome, thanks so much for the PR! I created a sub-issue (#562) specifically for the drift-detection and editing this PR summary to close out the sub-issue instead of the parent. |
jaypipes
requested changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch PRs that change Helm values but forget values.schema.json, as the first step of #536.
What was changed
Added a
helm-lintCI step that runshack/check-helm-values-schema.sh. The script fails whenhelm/temporal-worker-controller/values.yamlhas non-comment changes in the PR andvalues.schema.jsonwas not updated. Comment-only or whitespace-only edits are ignored.This is the first of the two steps from #536 (detect drift). Auto-generating
values.schema.jsoncan follow in a later PR.Why?
values.schema.jsonhas been falling out of date when Helm values change. A CI check makes that mismatch visible on the PR instead of relying on reviewers to notice.Checklist
Closes Detect drift in
values.schema.jsonfile #562How was this tested:
./hack/check-helm-values-schema.shon this branch skips (novalues.yamlchange)newKey: truetovalues.yamlwithout touching the schema fails the scriptvalues.yamlchanges still passAny docs updates needed?
No. Schema generation is still manual; this PR only adds the check.