Skip to content

helm: fail CI when values.yaml changes without a schema update - #561

Open
kriyanshii wants to merge 5 commits into
temporalio:mainfrom
kriyanshii:helm/check-values-schema-sync
Open

helm: fail CI when values.yaml changes without a schema update#561
kriyanshii wants to merge 5 commits into
temporalio:mainfrom
kriyanshii:helm/check-values-schema-sync

Conversation

@kriyanshii

@kriyanshii kriyanshii commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Catch PRs that change Helm values but forget values.schema.json, as the first step of #536.

What was changed

Added a helm-lint CI step that runs hack/check-helm-values-schema.sh. The script fails when helm/temporal-worker-controller/values.yaml has non-comment changes in the PR and values.schema.json was not updated. Comment-only or whitespace-only edits are ignored.

This is the first of the two steps from #536 (detect drift). Auto-generating values.schema.json can follow in a later PR.

Why?

values.schema.json has been falling out of date when Helm values change. A CI check makes that mismatch visible on the PR instead of relying on reviewers to notice.

Checklist

  1. Closes Detect drift in values.schema.json file #562

  2. How was this tested:

    • ./hack/check-helm-values-schema.sh on this branch skips (no values.yaml change)
    • Adding newKey: true to values.yaml without touching the schema fails the script
    • Comment-only values.yaml changes still pass
    • Updating both files passes
  3. Any docs updates needed?
    No. Schema generation is still manual; this PR only adds the check.

Catch PRs that change Helm values but forget values.schema.json, as the first step of temporalio#536.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kriyanshii
kriyanshii requested review from a team, eniko-dif and jlegrone as code owners August 31, 2026 18:59
@jaypipes

jaypipes commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

@kriyanshii awesome, thanks so much for the PR! I created a sub-issue (#562) specifically for the drift-detection and editing this PR summary to close out the sub-issue instead of the parent.

Comment thread hack/check-helm-values-schema.sh Outdated
Comment thread .github/workflows/helm-validate.yml Outdated
@kriyanshii
kriyanshii requested a review from jaypipes September 3, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect drift in values.schema.json file

2 participants