helm: generate values.schema.json from values.yaml - #565
Open
kriyanshii wants to merge 5 commits into
Open
Conversation
kriyanshii
requested review from
a team,
eniko-dif and
jlegrone
as code owners
September 1, 2026 19:34
Collaborator
|
Hey @kriyanshii Thanks for submitting this PR. We'll get this reviewed once you fix the linter errors. |
Contributor
Author
|
@tomba7 fixed the lint errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate
values.schema.jsonfromvalues.yamlinstead of hand-editing it. Related to #563.What was changed
Added
hack/helm-values-schema, a small Go tool that infers a JSON Schema fromhelm/temporal-worker-controller/values.yaml(types plus descriptions from comments) and deep-mergeshack/helm-values-schema/overlay.jsonfor constraints that cannot be inferred (image.pullPolicyenums, CPU/memory patterns,extraEnvrequiringname, etc.).make helm-values-schemawritesvalues.schema.json. The Helm Validation workflow regenerates the file and fails if git is dirty, so the committed schema cannot drift.The regenerated schema now includes keys that were missing from the hand-written file (
podSecurityContext,containerSecurityContext,workerResourceTemplate,certmanager.install/caBundle) and drops unusedcrds.Why?
values.schema.jsonwas maintained by hand and fell behindvalues.yaml(#536 / #563). Generating it from values, plus a small overlay for real validation rules, keeps the schema in sync without relying onhelm schemaquirks.Checklist
Closes Generate
values.schema.jsonfile automatically #563How was this tested:
make helm-values-schemais idempotenthelm lint --strict helm/temporal-worker-controllerpasseshelm templatewithextraEnv[0]missingnameis still rejected by the schemaAny docs updates needed?
No. Run
make helm-values-schemaafter changingvalues.yamlorhack/helm-values-schema/overlay.json.