Conversation
# Conflicts: # src/rdf4cpp/util/Int128.hpp
|
liss-h
requested changes
Jul 28, 2025
liss-h
left a comment
liss-h
left a comment
Collaborator
There was a problem hiding this comment.
Could you add a little more context to the PR description? Like a summary of the changes and what the implications are (limits and such)
# Conflicts: # src/rdf4cpp/BigDecimal.hpp # src/rdf4cpp/datatypes/registry/util/CharConvExt.hpp
# Conflicts: # src/rdf4cpp/Timezone.hpp # src/rdf4cpp/datatypes/registry/util/DateTimeUtils.hpp
Collaborator
|
Note to self, review when 128bit integer PR is merged |
liss-h
added
the
pobr breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes date/time 128 bit integer from boost to builtin
__int128, to make calculations a lot faster.while the builtin has a smaller range than boost, both are bigger than what the
int64_tyear allows. therefore the usable range of date/time types stays the same.also fixes some possible (but very unlikely in regular use) overflow errors in date/time calculations (to trigger them, you need to use very big numbers, at least several orders of magnitude bigger than the end of the universe).