QVAC-23713 fix(minimax-h3): preserve tiled decode and effective fps - #28
Merged
Conversation
Restore the upstream tiled VAE path so H3 video frames do not corrupt, and mux the generated audio/video at the model-enforced 24 FPS.
dev-nid
reviewed
Aug 18, 2026
|
This now returns the effective FPS rather than always echoing the requested value. Could we update this sentence to match the behavior and line 1205? |
|
Not introduced by this PR. But just posting it MiniMax-H3 previews still use the requested FPS, while generation and final output use the enforced 24 FPS. |
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
Use one FPS resolver for generation and public callers, then configure CLI previews with the model's effective rate so H3 consistently uses 24 FPS.
Author
|
Addressed the remaining MiniMax-H3 review notes in 7adccbe:
The pending approval-status message needs reviewer action and has no code change. |
jpgaribotti
approved these changes
Aug 18, 2026
amangupta-tether
approved these changes
Aug 18, 2026
amangupta-tether
left a comment
There was a problem hiding this comment.
Just some non-blocking comments
added 5 commits
August 18, 2026 14:49
Use the public effective-FPS API in generation and warn when callers request the H3 decode mode that intentionally uses the tiled path.
Use the 2026-08-11 GGML revision that removes the duplicate Vulkan gradient declaration blocking Linux and Windows CI.
Support FL2VA and REF2VA GGUF selections with verified shared VAE downloads for reproducible MiniMax-H3 testing.
Pair realrebelai denoisers with the stable-diffusion.cpp compatible Unsloth Qwen3-VL GGUF instead of ComfyUI-specific encoder layouts.
Prevent the realrebelai download helper from presenting ComfyUI-layout checkpoints as stable-diffusion.cpp-compatible H3 models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
build-clion macstudio