ci: 👷 add deploy preview and cleanup jobs to deploy workflow - #24
Closed
iamnewton wants to merge 7 commits into
Closed
ci: 👷 add deploy preview and cleanup jobs to deploy workflow#24iamnewton wants to merge 7 commits into
iamnewton wants to merge 7 commits into
Conversation
Signed-off-by: super-linterbot[bot] <310376783+super-linterbot[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 105 105
Branches 18 18
=========================================
Hits 105 105
|
…: true Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
domain field on HolocronConfig was added after 3.29.12; bumping to the current release unblocks the tsc check in the deploy preview PR. Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
domain field on HolocronConfig was added after 3.29.12; bumping to the current release unblocks the tsc check. Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
github-actions
Bot
temporarily deployed
to
theholocron-preview (Preview)
August 28, 2026 19:38
Inactive
Contributor
Author
|
Superseded by #29 — the nodeDocs() preset adoption already includes deploy+preview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds deploy preview and cleanup to the deploy workflow, matching the setup already in
theholocron/clientsandtheholocron/holocron.deploy.yml:pull_requesttrigger withtypes: [opened, synchronize, reopened, closed]and matchingpathsconcurrencyto use a PR-scoped group and skip cancellation onclosedeventspermissionsto includedeployments: writeandpull-requests: writedeployjob withif: github.event_name != 'pull_request'previewjob (Cloudflare Pages branch deployment on PR open/update)cleanupjob (deletes the CF Pages deployment on PR close/merge)holocron.config.ts:preview: { project: "theholocron-preview", domain: "preview.theholocron.dev" }to thedeployworkflow config soholocron syncregenerates this correctly in the future.