fix: 🐛 ignore @astrojs/react in knip config - #31
Merged
Conversation
…not as static import packages/components-doc has sandbox.tsx requiring the React integration, but @astrojs/react is declared as an Astro integration in the root astro.config.ts rather than statically imported in the package. Knip cannot trace this link and flags it as an unused devDependency. Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 105 105
Branches 18 18
=========================================
Hits 105 105
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knip flags
@astrojs/reactas an unused devDependency inpackages/components-docbecause it's registered as an Astro integration in the rootastro.config.tsrather than statically imported in the package.packages/components-dochassandbox.tsxwhich requires the React integration to render, but Knip cannot trace the link from the integration declaration to the package-level dependency. Adding it toignoreDependenciesunblocks the Dependabot PR (#25) and any future bumps of this package.