fix(deploy): 🐛 remove stale name: input from deploy workflow - #258
Merged
Conversation
Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
|
Tip All tests passed and all changes approved!🟢 UI Tests: 15 tests unchanged |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #258 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 6 6
Lines 87 87
Branches 11 11
=======================================
Hits 83 83
Misses 2 2
Partials 2 2 🚀 New features to boost your workflow:
|
react
 |
||||||||||||||||||||||||||||
| Project |
react
|
| Branch Review |
fix/remove-stale-name-from-deploy
|
| Run status |
|
| Run duration | 01m 05s |
| Commit |
|
| Committer | Newton |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
1
|
| View all changes introduced in this branch ↗︎ | |
Contributor
Author
|
🎉 This PR is included in version 0.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
react
|
||||||||||||||||||||||||||||
| Project |
react
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 01m 05s |
| Commit |
|
| Committer | Newton |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
1
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
name: theholocron/react-templateinput that was injected by the now-removed-sitepackage pattern (fixed in holocron #463). Thenameinput no longer exists on the reusabledeploy.yml; leaving it caused the deploy to trypnpm --filter @theholocron/react-template-site buildwhich doesn't exist.