fix(config): 🐛 merge chromatic and user-flow into react() test param - #262
Merged
Conversation
Avoids a second test workflow entry that previously caused the sync tool to use last-entry-wins and drop run-unit: false, run-storybook: true, and run-interaction: true. Merging all overrides into the single react() call ensures holocron sync always generates one complete test.yml. Depends on theholocron/configs#419 for react() to accept the test param. Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
|
Tip All tests passed and all changes approved!🟢 UI Tests: 15 tests unchanged |
react
 |
||||||||||||||||||||||||||||
| Project |
react
|
| Branch Review |
fix/use-react-preset-test-param
|
| Run status |
|
| Run duration | 01m 04s |
| Commit |
|
| Committer | Newton |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
1
|
| View all changes introduced in this branch ↗︎ | |
Signed-off-by: super-linterbot[bot] <310376783+super-linterbot[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #262 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 6 6
Lines 87 87
Branches 11 11
=======================================
Hits 83 83
Misses 2 2
Partials 2 2 🚀 New features to boost your workflow:
|
Picks up the test param on react() from configs#419. Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
Contributor
Author
|
🎉 This PR is included in version 0.5.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
iamnewton
added a commit
that referenced
this pull request
Aug 31, 2026
* chore: 🔧 sync from holocron.config Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(release): 0.5.6 [skip ci] ## [0.5.6](v0.5.5...v0.5.6) (2026-08-31) ### Bug Fixes * **config:** 🐛 merge chromatic and user-flow into react() test param ([#262](#262)) ([9a5c8cf](9a5c8cf)), closes [theholocron/configs#419](theholocron/configs#419) ### Chores * sync README and repo metadata ([#261](#261)) ([fc99040](fc99040)) Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com> * chore: 🔧 fix linting issues Signed-off-by: super-linterbot[bot] <310376783+super-linterbot[bot]@users.noreply.github.com> * chore: 🔧 fix linting issues Signed-off-by: super-linterbot[bot] <310376783+super-linterbot[bot]@users.noreply.github.com> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com> Signed-off-by: super-linterbot[bot] <310376783+super-linterbot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: super-linterbot[bot] <310376783+super-linterbot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testworkflow entry fromworkflows— it causedholocron syncto see twotestentries and use last-entry-wins, strippingrun-unit: false,run-storybook: true, andrun-interaction: truefrom the generatedtest.ymlrun-chromaticand addsrun-user-flow: trueintoreact({ test: {...} })so all options merge into one entrypresetvariable consistently (...preset,...preset.repo,...preset.workflows,...preset.providers) instead of destructuringDepends on
testparam toreact()so the TypeScript type accepts this callTest plan
@theholocron/holocron-configversion@theholocron/holocron-configto the new version in this repoholocron synclocally and verifytest.ymlhasrun-unit: false,run-storybook: true,run-interaction: true,run-user-flow: true, andrun-chromatic: true🤖 Generated with Claude Code