Fix macro collision: Replace print macros with inline template functions - #335
Open
berni2612 wants to merge 1 commit into
Open
Fix macro collision: Replace print macros with inline template functions#335berni2612 wants to merge 1 commit into
berni2612 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When compiling the
thelsing/knxlibrary in environments like ESP-IDF or ESPHome, it is often necessary to defineKNX_NO_PRINTto avoid conflicts with the host framework's UART implementation.The Issue
Currently, when
KNX_NO_PRINTis defined, the library falls back to C-style preprocessor macros:#define print(...) do {} while(0)This aggressive macro replacement causes severe naming collisions. If the host framework (e.g., ESP-IDF or ESPHome core files) uses
printorprintlnas legitimate method names inside other classes, the preprocessor blindly replaces them, resulting in fatalexpected unqualified-id before 'do'compilation errors.The Solution
This PR replaces the
#definemacros inbits.hwith emptystatic inline voidtemplate functions.This achieves the exact same zero-overhead behavior when
KNX_NO_PRINTis active, but safely respects C++ namespaces and class scopes, completely resolving the compilation errors in ESPHome/ESP-IDF integrations.