Enable two-center case in test_poisson_bvp_gives_the_correct_laplacian - #331
Open
Specter842 wants to merge 1 commit into
Open
Enable two-center case in test_poisson_bvp_gives_the_correct_laplacian#331Specter842 wants to merge 1 commit into
Specter842 wants to merge 1 commit into
Conversation
this was commented out as failing. it passes now with default params (verified locally, atol=1e-2, both on-grid and random points).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This case was commented out with
# TODO: Couldn't get the following test to pass.I ran it against current master (two Gaussians at (0,0,0) and (1,1,1), default params) and it passes: max abs error ~6e-3 on grid points and ~3e-14 on random points, both under the existing atol=1e-2. Looks like it was fixed as a side effect of other work since this was written, just never re-checked. Uncommenting it.