Refactor GitHub client into domain-specific files - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I split the monolithic
client.gofile ininternal/vcs/githubinto smaller, domain-specific files to improve maintainability and readability. The logic remains unchanged, but the code is now organized by domain:client_issues.go: Handles issue-related operations (fetching, creating, and listing issues).client_labels.go: Handles repository labels (fetching, creating, and validating labels).client_pr.go: Handles pull request operations (updating PRs, fetching PR data, and getting diffs).client_release.go: Handles release operations (creating, updating, and uploading binaries).This restructuring makes the GitHub client easier to navigate and maintain as the project grows.
Fixes #
Type of Change
How Has This Been Tested?
This is a pure refactoring of file structures without functional changes. Existing unit and integration tests should be run to verify that no behavior was broken.
Checklist
Test Plan & Evidence
Suggested Manual Verification
go test ./...and ensure all tests pass