Refactor internal packages and fix git add for staged deletions - #116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have reorganized several internal packages to improve the project's structure and simplify import paths. Specifically, the
costandroutingrelated services have been moved frominternal/services/costandinternal/services/routingtointernal/costandinternal/routingrespectively. Additionally, theCleanLabelshelper function has been moved frominternal/ai/gemini/helpers.gotointernal/ai/gemini/helper.go.I also addressed a bug in the
git_servicewhere callingAddFileToStagingon a file that was already staged for deletion would result in an error ("pathspec did not match any files"). The service now correctly handles this scenario as a no-op, preventing unnecessary failures.Fixes #
Type of Change
How Has This Been Tested?
TestAddFileToStaging/Already_fully_staged_deleted_file_is_a_no-op) that reproduces the original failure and verifies the corrected behavior. Existing unit tests for the refactored packages were updated to reflect the new import paths and continue to pass.Checklist
Test Plan & Evidence
Suggested Manual Verification
go test ./...and ensure all tests pass