feat(doctor): Add git identity fallback and improve output - #117
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I implemented a fallback mechanism for the
doctorcommand's Git identity checks. Previously, ifgit config user.nameoruser.emailwere not set, thedoctorcommand would report an error. With this change, ifmatecommithas aGitFallbackidentity configured, thedoctorcommand will now issue a warning instead of an error, indicating that the fallback identity will be used. This improves the user experience by providing more informative feedback and allowingmatecommitto function even without a globally configured Git identity.Fixes #
Type of Change
How Has This Been Tested?
I added new unit tests in
internal/commands/config/doctor_test.goto verify the behavior ofcheckGitUserNameandcheckGitUserEmail. These tests cover scenarios where:Git user identity is unset and no fallback is configured (expected error).
Git user identity is unset but a
matecommitfallback is configured (expected warning).Git user identity is properly configured (expected OK status).
Unit tests
Integration tests
Manual test: (describe below)
Checklist
Test Plan & Evidence
Suggested Manual Verification
go test ./...and ensure all tests pass