Fix config show: Correctly label config type and prevent duplication - #118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
config showcommand previously always printed "Global Configuration" initially, and then, if a local repository configuration existed, it would load and print it again under a "Local Configuration" header. This led to incorrect labeling (showing "Global" when a local config was active) and duplication of configuration details.I've modified
internal/commands/config/show.goto correctly identify if the active configuration is local (when inside a Git repository) or global, and print the appropriate header only once. This also removes the redundant logic that re-loaded and re-printed the local configuration.Fixes # (issue)
Type of Change
How Has This Been Tested?
A new unit test
labels the resolved config as local (not global) when run inside a repo, with no duplicate sectionwas added ininternal/commands/config/show_test.go. This test verifies that the output correctly identifies the configuration as "Local Configuration" when applicable, does not show "Global Configuration" in that scenario, and ensures that configuration details (like fallback identity) are printed exactly once.Checklist
Test Plan & Evidence
Suggested Manual Verification
go test ./...and ensure all tests pass