Fix: Improve CLI error handling and stats value formatting - #122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I improved the CLI error reporting across several commands. Specifically, I added
ui.PrintErrorcalls ininternal/commands/config/init.goandinternal/commands/config/set.goto ensure error messages are displayed to the user before the command exits. Ininternal/commands/issues/templates.go, I updated error handling to useui.HandleAppErrorfor a more consistent user experience. Additionally, thetemplates_already_existerror ininternal/services/issue_template_service.gonow includes a suggestion to use the--forceflag.I also addressed an issue with the display of monetary and percentage values in the
statscommand. Theinternal/commands/stats/stats.gofile was modified to format all relevant float values (totals, averages, projections, cache hit rates, saved amounts, and average costs) usingfmt.Sprintf("%.4f", value)before they are passed to the i18n templates. This prevents floating-point precision artifacts (e.g.,0.30000000000000004) from appearing in the user-facing output, ensuring clean and consistent numerical presentation.Fixes # (issue)
Type of Change
How Has This Been Tested?
Checklist
Test Plan & Evidence
Suggested Manual Verification
go test ./...and ensure all tests pass