Send a Google Chat notification when nightly E2E fails - #86
Merged
brionmario merged 1 commit intoAug 20, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
janithjay
force-pushed
the
add-e2e-nightly-chat-notification
branch
4 times, most recently
from
August 19, 2026 07:13
45ca9c2 to
ebe7368
Compare
Mirrors thunder-id/thunderid's nightly-build-validation.yml pattern, with threading added: every failure carries the same threadKey, so repeated nightly failures reply into one Google Chat thread instead of each posting a separate top-level message. Signed-off-by: janithjay <janithjayashan018@gmail.com>
janithjay
force-pushed
the
add-e2e-nightly-chat-notification
branch
from
August 20, 2026 08:50
ebe7368 to
cc12c4e
Compare
brionmario
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The nightly E2E workflow (
e2e-nightly.yml) runs on a schedule against the latest ThunderID release, but a failure was only ever visible if someone happened to check the Actions tab. Nothing surfaced it proactively.Approach
Added a Google Chat notification step, gated on
if: failure(), mirroringthunder-id/thunderid's ownnightly-build-validation.ymlpattern (jq-built card payload,curl -f, skips gracefully if the webhook secret isn't configured).One addition beyond thunderid's version: threading.
messageReplyOption=REPLY_MESSAGE_FALLBACK_TO_NEW_THREADis appended to the webhook URL and a fixedthread.threadKey(javascript-sdks-e2e-nightly) is included in the payload, so every nightly failure replies into the same Google Chat thread instead of posting a new top-level message each time.Requires a
GOOGLE_CHAT_WEBHOOKrepository secret (pointing at the same Chat space thunderid notifies) to actually send anything until it's set, the step logs and exits 0 without failing the job.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks