Fix nuxt/nextjs E2E flakiness and align CI step naming - #87
Merged
brionmario merged 1 commit intoAug 20, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
janithjay
marked this pull request as draft
August 20, 2026 05:32
Signed-off-by: janithjay <janithjayashan018@gmail.com>
janithjay
force-pushed
the
fix-nuxt-nextjs-e2e-timeouts
branch
from
August 20, 2026 07:19
43a034e to
812c40f
Compare
janithjay
marked this pull request as ready for review
August 20, 2026 07:43
brionmario
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
CI showed intermittent failures on the nuxt-quickstart and nextjs-quickstart E2E suites.
Root-caused it: the redirect landing page is server-rendered, so the user dropdown trigger can be visible before React/Vue finishes attaching its click handler. Under CI-level CPU contention that gap is wide enough to swallow the first click entirely no error, just a menu item that never appears and a test that hangs until timeout
Approach
tests/e2e/pages/thunderid-web-sample.page.ts: added a privateopenDropdown()helper used bylogout(),openTokenDebug(), andopenManageProfile(). It clicks the trigger, verifies the target menu item actually appeared, and retries the click (up to 3x) if it didn't. This fixes the race at its source instead of papering over it with a bigger timeout..github/workflows/pr-builder.yml,.github/actions/run-e2e-suite/action.yml: retitled the E2E job/step names to the Title Case convention.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks