Support to pass namespace query parameter in flow/meta request. - #89
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>
SajidMannikeri17
force-pushed
the
fix/Iss-2314
branch
from
August 20, 2026 11:35
1f1a663 to
5ea4121
Compare
ThaminduDilshan
approved these changes
Aug 20, 2026
brionmario
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Consumers had no way to send a
namespacequery parameter on/flow/metarequests, which is needed to resolve namespace-scoped i18n data (e.g. an entity's localized display name) alongside translations.Separately, found and fixed a related bug: when a
{{ meta(...) }}field (e.g.application.name) resolves to a value that is itself a{{ t(...) }}translation reference, the raw, unresolved template string rendered on screen instead of the translated text.Approach
namespaceprop, threaded throughThunderIDProvider→FlowMetaProvider→getFlowMeta. When set, it's included asnamespacein both the initial flow-meta fetch and everyswitchLanguage()call. Omitted by default, so existing consumers are unaffected; any consumer can pass whatever value fits their use case.resolveFlowTemplateLiterals: after a{{ meta(...) }}lookup, check if the resolved value is itself a{{ t(...) }}literal (via the existing, previously-unusedisTranslationFlowTemplateLiteralhelper) and resolve it throught()too. Scoped to the one case that actually occurs, not a generic recursive/looping resolver.resolveFlowTemplateLiterals(previously untested), including the nested-resolution case.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks