Skip to content

Support to pass namespace query parameter in flow/meta request. - #89

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
Infosys:fix/Iss-2314
Aug 20, 2026
Merged

Support to pass namespace query parameter in flow/meta request.#89
brionmario merged 1 commit into
thunder-id:mainfrom
Infosys:fix/Iss-2314

Conversation

@SajidMannikeri17

@SajidMannikeri17 SajidMannikeri17 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Purpose

Consumers had no way to send a namespace query parameter on /flow/meta requests, which is needed to resolve namespace-scoped i18n data (e.g. an entity's localized display name) alongside translations.

Separately, found and fixed a related bug: when a {{ meta(...) }} field (e.g. application.name) resolves to a value that is itself a {{ t(...) }} translation reference, the raw, unresolved template string rendered on screen instead of the translated text.


Approach

  • Added an optional namespace prop, threaded through ThunderIDProviderFlowMetaProvidergetFlowMeta. When set, it's included as namespace in both the initial flow-meta fetch and every switchLanguage() call. Omitted by default, so existing consumers are unaffected; any consumer can pass whatever value fits their use case.
  • Fixed resolveFlowTemplateLiterals: after a {{ meta(...) }} lookup, check if the resolved value is itself a {{ t(...) }} literal (via the existing, previously-unused isTranslationFlowTemplateLiteral helper) and resolve it through t() too. Scoped to the one case that actually occurs, not a generic recursive/looping resolver.
  • Added test coverage for resolveFlowTemplateLiterals (previously untested), including the nested-resolution case.

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d811155-d1aa-4993-b6e8-1734f938cb2c


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>
@brionmario
brionmario merged commit db4a3da into thunder-id:main Aug 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants