Skip to content

Coinbase Book Exception #36

Description

@timolson

When Coinbase is enabled in cointrader.properties, you get an exception from the XChange adapter about the service being unimplemented. Coinbase doesn't supply an order book since they are a market maker.

One way to resolve this is to mock an order book with one bid and one ask, at Coinbase's stated price, with the useraccount's trade limit as the volume. We should be able to get that information from the XChange class CoinbaseAccountServiceRaw

We should also have better configuration in the xchange properties to configure xchange queries. Look at the inner class XchangeData.FetchTradesRunnable.run() method, which gets called whenever a query is available from the RateLimiter.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions