Conversation
Steps to reproduce: 1. Go to the Songs tab. 1. Start playing a song by clicking it. 2. Select it by long clicking it. 3. Select another song. 4. Click pause. Expected: The song pauses and remains selected. Actual: The song pauses and is unselected, although the selection count still shows 2 songs selected.
timusus
pushed a commit
that referenced
this pull request
Sep 24, 2026
SongListViewModel keyed selection by the full Song data class, whose equals() includes playCount and lastPlayed. Playing or pausing a selected song mutates those fields and re-emits it from the repository, so the selection lookup by equality silently failed. Key selection by Song.id instead, which is stable across playback state changes. Changelog: A song no longer loses its selection mark in the Songs list when it starts or stops playing
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Expected:
The song pauses and remains selected.
Actual:
The song pauses and is unselected, although the selection count still shows 2 songs selected.