Fix samples - #100
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CrashKiOS sample projects to build/align with newer tooling and iOS/Gradle integration settings, and refreshes sample dependencies/configuration.
Changes:
- Update sample Gradle wrappers and tidy shared module Gradle scripts.
- Adjust CocoaPods integration (including xcconfig) and refresh Podfile.lock metadata.
- Update sample dependency wiring (Bugsnag link plugin substitution) and include Firebase config in the Crashlytics sample.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/sample-crashlytics/shared/shared.podspec | Adds xcconfig override (disables user script sandboxing) and fixes formatting. |
| samples/sample-crashlytics/shared/build.gradle.kts | Removes KotlinCompile JVM target task configuration. |
| samples/sample-crashlytics/ios/Podfile.lock | Updates checksums and recorded CocoaPods version. |
| samples/sample-crashlytics/gradle/wrapper/gradle-wrapper.properties | Bumps Gradle wrapper version for the Crashlytics sample. |
| samples/sample-crashlytics/gradle/libs.versions.toml | Removes crashkios-utils coordinates from the sample version catalog. |
| samples/sample-crashlytics/build.gradle.kts | Removes crashkios-utils buildscript classpath entry and normalizes formatting. |
| samples/sample-crashlytics/app/google-services.json | Adds Firebase configuration (includes an API key and project identifiers). |
| samples/sample-crashlytics/app/.gitignore | Stops ignoring google-services.json (so it can be committed). |
| samples/sample-bugsnag/shared/shared.podspec | Adds xcconfig override (disables user script sandboxing). |
| samples/sample-bugsnag/shared/build.gradle.kts | Removes KotlinCompile JVM target task configuration. |
| samples/sample-bugsnag/settings.gradle.kts | Adds composite-build substitution for the Bugsnag link Gradle plugin marker module. |
| samples/sample-bugsnag/gradle/wrapper/gradle-wrapper.properties | Bumps Gradle wrapper version for the Bugsnag sample. |
| samples/sample-bugsnag/CrashKiOSSampleIOS/Podfile.lock | Updates checksums and recorded CocoaPods version. |
Suppressed comments (1)
samples/sample-crashlytics/app/.gitignore:2
- Removing google-services.json from .gitignore means the Firebase config (including API key and project identifiers) will be tracked/committed by default. If the intent is to keep credentials/project bindings out of the repo, restore this ignore entry and provide setup instructions or a sample template file instead.
/build
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pushing this file in the PR directly contradicts what we wrote in the tutorial for CrhasKiOS:
Note, if your repo is public, you probably want to make sure to add Android's
google-services.jsonand iOS'sGoogleService-infofiles to your gitignore.
If this is intentional, then I'd argue that we should make this decision clear but point users to our docs. Let's not teach by counterexample
There was a problem hiding this comment.
It was ported from iOS sample project. That crashkiossample even does not exist because a java.io.FileNotFoundException is thrown when the app launches, so this file is more like a placebo than something meaninful.
| tasks.withType<KotlinCompile> { | ||
| kotlinOptions.jvmTarget = "1.8" | ||
| } | ||
|
|
There was a problem hiding this comment.
Why was this removed?
the compile options at lines 26-27 does target Java 1.8, so I'd assume we still have to reinforce compiling in 1.8 as well
There was a problem hiding this comment.
kotlinOptions is deprecated in Kotlin 2:
'val kotlinOptions: KotlinJvmOptions' is deprecated. Please migrate to the compilerOptions DSL. More details are here: https://kotl.in/u1r8ln.
No description provided.