Improve win32 portability of display and progressbar - #708
Open
fredemmott wants to merge 2 commits into
Open
Conversation
refs trabucayre#704 Modern Windows terminals support these escape sequences, but MSVC does not recognize `\e` as a valid escape sequence
- POSIX, Linux: returns 0 or 1 - MSDN `_isatty()` (isatty is macro for that): returns 0 or non-zero. In Windows Terminal, it's returning 64 for me Other calls are only checking truthiness, not explicitly for 1 refs trabucayre#704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\eisatty()returns 0 or non-zero (in my case, 64) instead of just '0 or 1'. All other callers of isatty in v1.1.1 only check truthiness, not == 1refs #704