Migrate to tlog policy - #1128
Open
BenBirt wants to merge 7 commits into
Open
Conversation
phbnf
reviewed
Aug 20, 2026
| } { | ||
| t.Run(test.desc, func(t *testing.T) { | ||
| opts := NewAppendOptions().WithWitnesses(witnesses, test.witnessOpts) | ||
| if len(opts.witnesses.Components) != 1 { |
Contributor
There was a problem hiding this comment.
Should this check len(opts.wintessPolicy.Witnesses)?
| } | ||
|
|
||
| // alloc returns a unique name, preferring want. | ||
| func (a *nameAllocator) alloc(want string) string { |
Contributor
There was a problem hiding this comment.
Should this block empty strings for "want"?Or maybe it's not relevant because no code would ever call that with an empty string?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is a continuation of @AlCutter's #1127. PR text copied below.)
This PR migrates Tessera to use the policy package from the formats repo when configuring witness and mirroring.
The old in-repo approach has been marked as deprecated, but an effort has been made to maintain backwards compatibility for folks already using that approach. This has made the diff quite a bit larger than it otherwise would have been.
Towards #1123