Skip to content

web: port live Spec 001 presentation to primary shells - #300

Merged
enricopiovesan merged 1 commit into
mainfrom
cursor/ticket-web-session-presentation-port-primary-a
Sep 7, 2026
Merged

web: port live Spec 001 presentation to primary shells#300
enricopiovesan merged 1 commit into
mainfrom
cursor/ticket-web-session-presentation-port-primary-a

Conversation

@enricopiovesan

Copy link
Copy Markdown
Contributor

Summary

  • Port A1 live Spec 001/002 presentation updates to doc-approval, meeting-notes, and loop web (shared event-ui-conformance helpers + onPresentation during submit).
  • Dedupe Trace Explorer sessionPresentation onto the package adapters.
  • Unit tests assert mid-stream loading before terminal loaded on each host.

Governing Spec

  • Specs 001 / 002
  • Public embedder subscribe/submit only; UI remains a rendering layer

Project Item

Definition of Done

  • Primary web shells notify/render Spec 001/002 fields from each subscribed event during submit
  • Trace Explorer uses package helpers
  • Mid-stream loading covered in host unit tests
  • No forced yield; no business-field invention
  • Tests/typecheck green for touched workspaces

Validation

npm run test -w apps/doc-approval/web-react
npm run test -w apps/meeting-notes/web-react
npm run test -w apps/loop/web-react
npm run test -w apps/trace-explorer/web-react
npm run typecheck -w apps/doc-approval/web-react
npm run typecheck -w apps/meeting-notes/web-react
npm run typecheck -w apps/loop/web-react
npm run typecheck -w apps/trace-explorer/web-react

Test plan

  • Host unit tests: loading → loaded callback sequences
  • Existing happy/error/reject paths still pass
  • Trace Explorer observe/map tests pass (incl. loading)

Made with Cursor

Wire doc-approval, meeting-notes, and loop to shared session helpers with per-event callbacks; dedupe Trace Explorer onto the package.

Co-authored-by: Cursor <cursoragent@cursor.com>
@enricopiovesan
enricopiovesan merged commit 2483404 into main Sep 7, 2026
8 checks passed
@enricopiovesan
enricopiovesan deleted the cursor/ticket-web-session-presentation-port-primary-a branch September 7, 2026 03:34
enricopiovesan added a commit that referenced this pull request Sep 7, 2026
Locks the web kit proof bar as Done after #298#300 and defers visible flash, blocked/ended demo, and native parity.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant