test: land Vitest 5 with jest-dom matcher types - #307
Merged
Conversation
Vitest 5's two-parameter Assertion no longer merges jest-dom's one-parameter augmentation, which blocked the npm-major Dependabot bump. Co-authored-by: Cursor <cursoragent@cursor.com>
enricopiovesan
enabled auto-merge (squash)
September 9, 2026 06:21
enricopiovesan
deleted the
cursor/ticket-land-vitest-5-jest-dom-types
branch
September 9, 2026 06:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^5.0.0npm-major bump (and matching@vitest/coverage-v8) that Dependabot build(deps-dev): Bump the npm-major group across 1 directory with 2 updates #306 could not merge.Matchersinterface so Testing Library DOM matchers typecheck undertsc -b.@testing-library/jest-domsetup import (the/vitestentry cannot resolvevitestfrom the hoisted jest-dom package in this workspace layout).Governing Spec
N/A — test-runner / types only. No architecture or runtime-contract change.
Project Item
land-vitest-5(Project 2PVTI_lADOEbiBt84BbzAzzg6FxKM)Definition of Done
vitest^4.1.11are onvitest^5.0.0(and@vitest/coverage-v8^5.0.0)tsc -brecognizes Testing Library DOM matchers (noTS2339ontoBeInTheDocument/toBeDisabled)Validation
npm run typechecknpm run lintnpm run testbash scripts/ci/repository_checks.shMade with Cursor