Skip to content

fix(discover): more representative goal set, drop the no-plan card #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enricopiovesan wants to merge 1 commit into from
Closed

fix(discover): more representative goal set, drop the no-plan card #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions src/scripts/discover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ const CONTRACT_SCHEMA_VERSION = '1.0.0';
const GOALS = [
{
id: 'coverage',
label: 'Score the uncertainty of a reporting period',
blurb: 'Target: uncertainty.score. Facts: a partial coverage state with two included and one pending reference.',
label: 'Score how uncertain a reporting period is',
blurb: 'Aggregate a period’s included and pending references, then score the remaining uncertainty — the planner chains summary.aggregate into uncertainty.score on its own.',
kind: 'chain',
target: { capability_id: 'uncertainty.score', capability_version: '1.1.0' },
candidate_refs: [
Expand All @@ -39,8 +39,8 @@ const GOALS = [
},
{
id: 'price',
label: 'Price a small quote',
blurb: 'Target: core.calculate-price. Facts: one line item, a versioned pricing config.',
label: 'Price a quote',
blurb: 'One line item, two units at $50, a versioned pricing config with no discounts or tax — target core.calculate-price.',
kind: 'single',
target: { capability_id: 'core.calculate-price', capability_version: '1.2.0' },
candidate_refs: [
Expand All @@ -56,16 +56,15 @@ const GOALS = [
},
},
{
id: 'noplan',
label: 'A goal with no structural path',
blurb: 'Target: core.calculate-price. Facts: only a currency — nothing produces the line items or pricing config it needs.',
kind: 'none',
target: { capability_id: 'core.calculate-price', capability_version: '1.2.0' },
id: 'luhn',
label: 'Check a card number',
blurb: 'Does a 16-digit number pass the Luhn checksum? Facts: one number string — target validation.validate-luhn.',
kind: 'single',
target: { capability_id: 'validation.validate-luhn', capability_version: '1.2.0' },
candidate_refs: [
{ namespace: 'core', id: 'core.calculate-price', versionRange: '1.2.0' },
{ namespace: 'summary', id: 'summary.aggregate', versionRange: '1.1.0' },
{ namespace: 'validation', id: 'validation.validate-luhn', versionRange: '1.2.0' },
],
starting_facts: { currency: 'USD' },
starting_facts: { number: '4242424242424242' },
},
];

Expand Down
16 changes: 9 additions & 7 deletions tests/e2e/discover.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,17 @@ test('goal 1 auto-plans on load, then review + execute for real against the live
await expect(page.locator('#discover-log')).toContainText('executed offline in your browser');
});

test('the no-structural-path goal returns "no plan" as a real outcome, not an error', async ({ page }) => {
test('a single-capability goal (card checksum) plans and executes for real', async ({ page }) => {
test.slow();
await page.goto('/discover.html');
await expect(page.locator('#discover-badge')).toHaveText('Planned — review the mappings', { timeout: 45_000 });

await page.locator('.discover-goal[data-goal="noplan"]').click();
await expect(page.locator('#discover-badge')).toHaveText('No plan — the goal has no structural path', { timeout: 45_000 });
await expect(page.locator('#discover-result')).toHaveAttribute('data-outcome', 'noplan');
await expect(page.locator('#discover-plan-mappings')).toContainText('No structural candidate');
await expect(page.locator('#discover-exec')).toBeHidden();
await expect(page.locator('#discover-log')).toContainText('0 candidates');
await page.locator('.discover-goal[data-goal="luhn"]').click();
await expect(page.locator('#discover-plan-target')).toHaveText('validation.validate-luhn@1.2.0', { timeout: 45_000 });
await expect(page.locator('#discover-badge')).toHaveText('Planned — review the mappings');

await page.locator('#discover-exec').click();
await expect(page.locator('#discover-badge')).toHaveText('Executed — real, offline, governed', { timeout: 45_000 });
await expect(page.locator('#discover-trace')).toContainText('terminal: succeeded');
await expect(page.locator('#discover-trace')).toContainText('validation.validate-luhn@1.2.0');
});
Loading