feat(discover): promote the doc-approval review chain to goal 1 - #78
Merged
Conversation
registry#424/#425 merged: doc-approval.analyze@1.4.0 -> doc-approval.recommend@1.4.0 now carry a pure_read / deterministic risk class and are is_automatic_eligible on the live catalog, so the two-node chain both plans *and* executes for real. - reorder GOALS so "Review a document for approval" is GOALS[0] (auto-plans on load), then "Price a quote", then "Check a card number" - e2e: goal 1 now asserts doc-approval.recommend@1.4.0 on load and both nodes (analyze + recommend) in the redacted trace after execute; add explicit plan+execute specs for the price and luhn single-capability goals Verified against the live registry: CHECK_REGISTRY=1 npm test green; all 3 Playwright specs green; browser run shows terminal: succeeded for the chain. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Now that
traverse-framework/registry#424/#425are merged,doc-approval.analyze@1.4.0 → doc-approval.recommend@1.4.0carry apure_read/deterministicrisk class and areis_automatic_eligibleon the live catalog. The two-node chain therefore both plans and executes for real in-browser — it is the most representative goal we have, so it should be the one the page runs on arrival.GOALSinsrc/scripts/discover.jsso "Review a document for approval" isGOALS[0](auto-plans on load), followed by "Price a quote" and "Check a card number". No other logic changes —GOALS[0]was already the only ordering reference.tests/e2e/discover.spec.mjs:doc-approval.recommend@1.4.0as the plan target on load, and bothdoc-approval.analyze@1.4.0anddoc-approval.recommend@1.4.0in the redacted per-node trace after execute.priceandluhnsingle-capability goals (previouslypricewas only covered implicitly as the on-load goal).This is the follow-up promised in
#77.Verification
CHECK_REGISTRY=1 npm test— 6/6 green (includes the networked live plan + composed-execute).npx playwright test— 3/3 green.npm run build— 92 pages, clean.doc-approval.analyze → doc-approval.recommend, review gate clearsmapping_unconfirmed,executeBrowserComposedWorkflowreturnsterminal: succeededwith both nodessucceeded.🤖 Generated with Claude Code