Skip to content

feat(discover): promote the doc-approval review chain to goal 1 - #78

Merged
enricopiovesan merged 1 commit into
mainfrom
discover-docapproval-first
Sep 10, 2026
Merged

feat(discover): promote the doc-approval review chain to goal 1#78
enricopiovesan merged 1 commit into
mainfrom
discover-docapproval-first

Conversation

@enricopiovesan

Copy link
Copy Markdown
Collaborator

What

Now that traverse-framework/registry#424 / #425 are merged, doc-approval.analyze@1.4.0 → doc-approval.recommend@1.4.0 carry a pure_read / deterministic risk class and are is_automatic_eligible on the live catalog. The two-node chain therefore both plans and executes for real in-browser — it is the most representative goal we have, so it should be the one the page runs on arrival.

  • Reorder GOALS in src/scripts/discover.js so "Review a document for approval" is GOALS[0] (auto-plans on load), followed by "Price a quote" and "Check a card number". No other logic changes — GOALS[0] was already the only ordering reference.
  • tests/e2e/discover.spec.mjs:
    • Test 1 now asserts doc-approval.recommend@1.4.0 as the plan target on load, and both doc-approval.analyze@1.4.0 and doc-approval.recommend@1.4.0 in the redacted per-node trace after execute.
    • Added explicit plan+execute specs for the price and luhn single-capability goals (previously price was only covered implicitly as the on-load goal).

This is the follow-up promised in #77.

Verification

  • CHECK_REGISTRY=1 npm test — 6/6 green (includes the networked live plan + composed-execute).
  • npx playwright test — 3/3 green.
  • npm run build — 92 pages, clean.
  • Browser run against the live registry: goal 1 auto-plans to doc-approval.analyze → doc-approval.recommend, review gate clears mapping_unconfirmed, executeBrowserComposedWorkflow returns terminal: succeeded with both nodes succeeded.

🤖 Generated with Claude Code

registry#424/#425 merged: doc-approval.analyze@1.4.0 -> doc-approval.recommend@1.4.0
now carry a pure_read / deterministic risk class and are is_automatic_eligible on
the live catalog, so the two-node chain both plans *and* executes for real.

- reorder GOALS so "Review a document for approval" is GOALS[0] (auto-plans on
  load), then "Price a quote", then "Check a card number"
- e2e: goal 1 now asserts doc-approval.recommend@1.4.0 on load and both nodes
  (analyze + recommend) in the redacted trace after execute; add explicit
  plan+execute specs for the price and luhn single-capability goals

Verified against the live registry: CHECK_REGISTRY=1 npm test green; all 3
Playwright specs green; browser run shows terminal: succeeded for the chain.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@enricopiovesan
enricopiovesan merged commit 361b62c into main Sep 10, 2026
5 checks passed
@enricopiovesan
enricopiovesan deleted the discover-docapproval-first branch September 10, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant