feat: session metadata on create/update/read - #544
Merged
Conversation
sr07asthana
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
thesujai
as code owners
September 2, 2026 07:50
🦋 Changeset detectedLatest commit: e539158 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c6aa107. Configure here.
heerambavi1998
approved these changes
Sep 2, 2026
heerambavi1998
left a comment
heerambavi1998
left a comment
Contributor
There was a problem hiding this comment.
Please confirm the expected behaviour on PUT requests where metadata is not sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Adds a required API field and DB migrations (including a SQLite session table rebuild); behavior is additive for clients that ignore unknown fields but breaking for strict SDK consumers expecting the old session shape.
Overview
Adds caller-owned session metadata as a string map (
Record<string, string>) separate from existing sessioncustom, with validation aligned to gateway header limits (keys 1–32 chars, values ≤128, at most 50 keys).API & core: Optional
metadataon create and PATCH;metadatais required on session responses. PATCH uses full replace whenmetadatais sent ({}clears); omitted fields leave the map unchanged.Sessions.createdefaults missing metadata to{};SessionHandleexposes ametadatagetter.Persistence: New
session.metadataJSON column (Postgresjsonbwith default{}; SQLite table rebuild). Postgres and SQLite session stores read/write and validate metadata on load; in-memory store matches the same contract.SDK/OpenAPI:
SessionMetadatatype and wire serialization updates across generated SDK and OpenAPI specs.Reviewed by Cursor Bugbot for commit e539158. Bugbot is set up for automated code reviews on this repo. Configure here.