trunk-merge/pr-1170/bdd0ded4-0924-40fd-a325-d752a20a789c - #1176
Closed
trunk-io[bot] wants to merge 4 commits into
Closed
trunk-merge/pr-1170/bdd0ded4-0924-40fd-a325-d752a20a789c#1176trunk-io[bot] wants to merge 4 commits into
trunk-io[bot] wants to merge 4 commits into
Conversation
GitHub evaluates a job's `if:` before expanding its matrix, so a matrix job
skipped at job level reports one check run under the unexpanded name --
`Build CLI for ${{ matrix.platform.target }}` rather than one context per
platform. Any per-leg context required by branch protection then never
reports and the PR hangs on "Expected -- Waiting for status to be reported".
Each PR workflow now ends in a `gate` job that always runs and passes when
every job it needs finished success-or-skipped. That gives branch protection
one stable context per workflow instead of 12 hand-typed matrix-leg names
that also break on any matrix edit (runner labels and Xcode versions are
currently baked into them).
Each gate's `needs` lists the jobs that are required checks today, so the
required set is preserved rather than widened. It also removes a latent
ambiguity: the required context `build` currently matches the `build` job in
both ruby.yml and wasm.yml.
No behavior change on its own -- the gate only aggregates results.
The gate only reads `needs.*.result`, so anything beyond a few seconds means it is wedged rather than working -- and a wedged required check blocks merges until the default 6h job timeout expires.
Adds the Dynamic CI Filter in pre-job mode to the four PR workflows (pull_request, pyo3, ruby, wasm): one upstream job asks Trunk for a per-job verdict and every downstream job gates on its output. Gating is scoped to pull_request explicitly -- every gate leads with `github.event_name != 'pull_request' ||`, so push (main), tags and workflow_dispatch run everything outright rather than relying on the skipped filter job's empty outputs. Unlike trunk2, TRUNK_PUBLIC_API_ADDRESS is left unset so the action talks to prod (api.trunk.io) with TRUNK_PROD_ORG_API_TOKEN -- this repo's merge queue and CI history are in prod, not staging.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
+ Coverage 83.07% 83.31% +0.23%
==========================================
Files 72 72
Lines 16313 16313
==========================================
+ Hits 13552 13591 +39
+ Misses 2761 2722 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trunk-io
Bot
deleted the
trunk-merge/pr-1170/bdd0ded4-0924-40fd-a325-d752a20a789c
branch
August 27, 2026 18:35
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 8c100a4ed6601942309b99936f0668483ab100ff.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 1170, stacked on pull request 1173.