fix(ci): drop ripgrep from architecture gate and pin CI inputs - #93
Merged
Merged
Conversation
GitHub runners do not ship rg, so check-architecture-boundaries.sh failed after SCI/SPDP checks on main and PR 92. Use grep/python3, pin the Inauguration compiler to the vendored SHA, pin Bun/v86/wrangler, and add orb setup/resume scripts. Amp-Thread-ID: https://ampcode.com/threads/T-01a0a632-f73d-76d8-bd54-0fe7e1a9481e Co-authored-by: Max Carter <undivisible@vk.com>
|
Capy couldn't review this pull request because Max's workspace is out of credits, add credits or enable auto-reload to resume automatic reviews. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_95a53d3c-dfb1-4628-8762-b95fd560bb11) |
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scripts/check-architecture-boundaries.shshells out torg. GitHub-hosted runners do not install ripgrep, so CI onmain(since2defc9f) and PR #92 fail after the SCI/SPDP checks withrg: command not found.What
grep+python3(already on runners).2e3bf26instead of floatingmaster.1.3.10; pinv86/wranglerto the versions already inbun.lock..agents/setupand.agents/resumefor Amp orbs (nasm, QEMU, clang, Rust, Inauguration submodule, website install)..amp/portals/.Verify
bash scripts/check-architecture-boundaries.sh→PASS: architecture boundariesbash scripts/check-spdp-protocol.sh→ 34 passedcd website && bun install --frozen-lockfile && bun run typecheck && bun test→ 11 pass.agents/setupwarm ~0.16s;.agents/resume~0sMerge
Narrow tooling/CI. No kernel, boot, privilege, or networking-policy changes. Auto-merge only after CI is green.
Does not replace PR #92 (kernel isolation honesty + syscall caps). That PR remains review-only.
Note
Low Risk
Tooling and CI-only changes; architecture checks are preserved with different host tools and no kernel or security logic is modified.
Overview
Fixes CI failures where the architecture boundary gate called
rg, which GitHub runners do not ship, by reimplementing the same checks withgrepand a smallpython3assertion onsys-cap-mintinscripts/check-architecture-boundaries.sh.CI and dependency pinning: the reusable kernel job now passes
inauguration-refto the vendored Inauguration SHA; the website job pins Bun 1.3.10 andpackage.json/bun.lockpinv86andwranglerinstead oflatest.Agent orb ergonomics: adds
.agents/setup(apt/Rust/submodule/website install) and.agents/resume(fast PATH/tool checks), and ignores.amp/portals/in.gitignore. No kernel, boot, or runtime policy code changes.Reviewed by Cursor Bugbot for commit 09893bb. Configure here.