Keep the permission prompt inside the user's gesture on Firefox - #12
Merged
Merged
Conversation
From the review on #11. Firefox allows permissions.request only while the user's gesture is live, and any earlier await in the handler ends it. The "no active window" fix awaited permissions.contains first, which would have broken every save that needs a prompt on Firefox desktop: Vercel, TypeSafe, and custom endpoints. The granted origins are now read once when the popup opens (and again on every grant or revocation), the comparison is synchronous, and the prompt is the first thing the save handler awaits. A grant that covers every site counts as covering the origin.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to CodeRabbit's comment on #11, which was right: Firefox allows
permissions.requestonly while the user's gesture is live, and any earlierawaitin the handler ends it. #11 awaitedpermissions.containsfirst, which would have broken every save that needs a prompt on Firefox desktop (Vercel, TypeSafe, custom endpoints).permissions.onAdded/onRemoved.ensureOriginscompares synchronously and callspermissions.requestbefore yielding; a test asserts the request is already in flight when the function returns.https://*/*,<all_urls>) counts as covering the origin, so an all-sites grant is never re-asked.The Kiwi fix from #11 stands: an origin the manifest already covers is never requested. 128 tests pass. Not tried on Firefox or a phone; reasoned from the docs and covered by unit tests.