[pull] master from php:master - #1242
Merged
Merged
Conversation
php_imagettftext_common() serves the bbox functions, where $size is argument #1, and the drawing ones, where it is #2, but its two size checks hardcode 2. imageftbbox(NAN, ...) therefore blamed $angle. Also fix the upper bound itself: (double)LONG_MAX rounds up to 2^63, so (double)LONG_MAX / 64 is 2^57 and the check let 2^57 through, whose product with 64 is LONG_MAX + 1. The bound is now exclusive, and the reported values use integer division, which gives the largest size that is actually representable. The lower bound stays inclusive: (double)LONG_MIN / 64 is exactly -2^57 and its product with 64 is LONG_MIN. Co-authored-by: NickSdot <32384907+NickSdot@users.noreply.github.com> Close GH-23541
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )