[pull] master from ruby:master - #1380
Merged
Merged
Conversation
(ruby/prism#4221) Ref https://bugs.ruby-lang.org/issues/22294 pm_check_value_expression descended the left operand of every and/or node it visited. Because pm_and_node_create and pm_or_node_create already assert the value of their left operand when the node is built, walking a left-associative chain such as `a && a && ... && a` re-checked the whole left spine once per operator, which is quadratic in the length of the chain: 16k operators took seconds. The left operand of an existing and/or node was therefore already checked, so stop at the node instead of descending. This makes the check linear. The only observable change is that a void value on the left spine of a chain is now reported once, at the innermost node where it is created, rather than once per enclosing operator; the errors fixture that pinned the duplicate is updated to match. ruby/prism@b19a0a5bc0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )