Quick fix no dialog when no subfeatures are present - #18
Open
bejo-dionnez wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix in the case that no subfeatures are present (feature.get("subfeatures") returns undefined and therefore _isSingle returns undefined) (I believe this issue is mentioned in issue #11 ). For the cases of annotation files with only one attribute.
In the case there are no "child" attributes/subfeatures JBrowse will now show a dialog that no subfeatures are present. Preferably it might show the fasta sequence, but is also present in the normal details box from JBrowse.