Bulk FHIR Gen 3 Authorization Tagging - #313
Open
dsafarian wants to merge 11 commits into
Open
Conversation
… remove unecessary dependencies
Avantol13
reviewed
Aug 20, 2026
| cdisutilstest = { git = "https://github.com/uc-cdis/cdisutils-test.git", tag = "2.0.0" } | ||
| indexd = { git = "https://github.com/uc-cdis/indexd.git", tag = "5.0.4" } | ||
| deptry = "^0.23.1" | ||
| setuptools = "<82" |
Contributor
There was a problem hiding this comment.
why was this necessary? let's try without it
Avantol13
reviewed
Aug 20, 2026
|
|
||
| `gen3 fhir --help` | ||
|
|
||
| For example, the following tags the 'Patient.ndjson' file with Gen3 authorization and outputs 'gen3_Patient.ndjson' using the authorization rules from 'config.yaml' |
Contributor
There was a problem hiding this comment.
can you add some more details about the configuration and how to configure different rules?
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
Contributor
There was a problem hiding this comment.
let's add a README.md to this test_data directory that explains that this is all synthetic data generated
Contributor
There was a problem hiding this comment.
and clarify which FHIR implementation guide / model. I assume this is the default FHIR model. Did you use a specific FHIR version?
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
| # return rule["authz"] | ||
| for rule in self.rules: | ||
| match = evaluate(resource, rule["condition"]) | ||
| if match and match[0] is True: # FIXME: what if multiple conditions match? |
Contributor
There was a problem hiding this comment.
for the FIXME: we should maybe log a warning
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
| resource["meta"]["security"] = [] | ||
|
|
||
| gen3_security_tag = { | ||
| "system": "http://gen3.org/authz", |
Contributor
There was a problem hiding this comment.
this path should be configuration or at least a global variable at the top of this file
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
Avantol13
reviewed
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features
Dependency updates