ci: harden daily Docker dependency updater - #158
Open
fqjony wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the GitHub Actions workflow that probes Dockerfile dependencies and opens an automated, Dockerfile-only update PR, and documents the updater behavior in the README.
Changes:
- Switch the dependency updater schedule to run daily at 05:00 UTC.
- Tighten Copilot CLI execution by validating inputs, limiting allowed URLs to those found in the Dockerfile report, and guarding against non-Dockerfile changes (including staged changes).
- Extend the dependency report to include an inventory of Dockerfile
ARGpins and URL sources, and document the updater behavior inREADME.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Documents when/how the Docker dependency updater runs and what it does. |
| .github/workflows/docker-dependency-updater.yml | Hardens the scheduled dependency-updater workflow, adds non-APT inventory to the report, and tightens Copilot execution/guards. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
.github/workflows/docker-dependency-updater.yml:223
- This step runs an inline Node script to inventory Dockerfile ARGs/URLs, but Node isn’t set up/pinned until later (
actions/setup-node). That makes the probe depend on whatever Node version happens to be preinstalled on the runner image and can drift/break independently of the pinned Node 22 used later in the job.
node <<'NODE' > "${non_apt_path}"
const fs = require("node:fs");
const dockerfile = fs.readFileSync(process.env.DOCKERFILE, "utf8");
const pins = [];
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Validation
.rabbit/repo.yamlfrom the current GitHub delivery configuration and confirmed a stable dry run.