Quick-fix batch: pressure nullspace, mesh cache filename, test number - #619
Merged
Conversation
Three small independent fixes, each closing an issue that did not warrant its own change. #577. CylindricalStokes(boundary="zero") returned before the line that removes the pressure nullspace, so the zero-slip case ran a singular saddle and could return a quiet, wrong pressure. The nullspace belongs to the DOMAIN rather than to the wall type — both cases here are an enclosed annulus — so it is now set once after the branch. Verified by reading petsc_use_pressure_nullspace back off the solver for both boundary values; it was None for "zero" before and is True for both now. #618. The StructuredQuadBox mesh cache filename omitted elementRes, so every box on the same coordinates shared one path whatever its resolution and two processes at different resolutions raced on it. Resolution is now part of the name, as the annulus already does with its cell size. Verified: 4x4 and 8x8 now write uw_structuredQuadBox_..._res(4, 4).msh and _res(8, 8).msh. #600. test_1029_analytic_zhong2008.py collided with test_1029_analytic_faulted_medium.py — the two PRs were written against different bases and neither could see the other's number. Renamed to 1030; the faulted medium keeps 1029 because it merged first. The reference in docs/developer/subsystems/analytic-solutions.md is updated and no stale mention remains. Closes #577, #600, #618. Full ./uw test 1556 passed; the analytic contract, conformance and Zhong files 132 passed. Underworld development team with AI support from Claude Code
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #577. Closes #600. Closes #618.
Three small independent fixes, batched because none warrants its own change —
the same shape as #456 and #532.
#577 — the zero-slip annulus ran a singular saddle
CylindricalStokes.apply_boundary_conditionsreturned before the line thatremoves the pressure nullspace:
Both cases are an enclosed annulus, so in both the pressure is determined only
up to a constant. The nullspace belongs to the domain, not to the wall type, and
is now set once after the branch.
Measured, reading the flag back off the solver:
boundary"zero"True"free"TrueTrue#618 — one cache file for every resolution
elementReswas not in the name, so everyStructuredQuadBoxon the same boxwrote and read one path whatever its resolution, and two processes at different
resolutions raced on it. The annulus already carries its cell size for this
reason. Resolution is now part of the name; a 4x4 and an 8x8 produce
..._res(4, 4).mshand..._res(8, 8).mshwhere they previously produced onefile between them.
#600 — two test files numbered 1029
test_1029_analytic_zhong2008.pycollided withtest_1029_analytic_faulted_medium.py; the two PRs were written againstdifferent bases and neither could see the other's choice. Zhong moves to 1030,
the faulted medium keeps 1029 because it merged first. The reference in
docs/developer/subsystems/analytic-solutions.mdis updated and no stalemention remains anywhere in
src/,tests/,docs/orscripts/.Verified
Full
./uw test: 1556 passed, 32 skipped, 2 xfailed. The analytic contract,conformance and Zhong files: 132 passed.
Underworld development team with AI support from Claude Code