fix: require the image check for containers - #243
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesContainers check requirements
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The containers repository will require the image summary check in addition to build, ensuring matrix image results gate merges. No merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The required status check contexts now align with the actual GitHub Actions job names and the change is narrowly scoped to ruleset configuration.
Pull request overview
Updates the GitHub ruleset configuration for the unmango/containers repository so required status checks match the actual GitHub Actions job names produced by CI, preventing PRs from being blocked by a non-existent build context.
Changes:
- Replace the single required check
buildwith the per-system matrix job contexts (build (x86_64-linux),build (aarch64-linux),build (aarch64-darwin)). - Add
manifestsandenumerateas additional required checks to align with the repo’s CI/workflow coverage.
File summaries
| File | Description |
|---|---|
| index.ts | Updates containers repo githubChecks to require the correct matrix job contexts and add manifests/enumerate. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
🍹 The Update (preview) for UnstoppableMango/unmango-github/prod (at 28f85c9) was successful. Resource Changes Name Type Operation
~ containers github:index/repositoryRuleset:RepositoryRuleset update
|
54cf830 to
ca459fe
Compare
unmango/containers ends each workflow in a summary job that needs the rest of its own jobs: `build` for CI, `image` for Images. The real work runs in matrices over systems and images, which report a status context per leg and cannot be required here without naming every one. `build` was already required, so this adds `image`, which gates building every image on both architectures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
image check for containers
ca459fe to
28f85c9
Compare
unmango/containersends each of its two workflows in a summary job thatneedsthe rest of that workflow's jobs:buildcheck (<system>)×3,manifestsimageenumerate,image (<image>, <arch>)×10The real work runs in matrices, which report a context per leg. A ruleset cannot require those without naming every system and every image, so it would need editing here each time an image is added. The summary jobs give two stable names instead.
buildwas already required, so this only addsimage— which is the one that actually gates building every image on both architectures.Verified
pulumi preview --diffagainstprod:dprint checkandmake lintpass.Context: unmango/containers#1.
Summary by CodeRabbit
Chores
Documentation