Skip to content

fix: require the image check for containers - #243

Merged
UnstoppableMango merged 1 commit into
mainfrom
fix-containers-checks
Sep 5, 2026
Merged

fix: require the image check for containers#243
UnstoppableMango merged 1 commit into
mainfrom
fix-containers-checks

Conversation

@UnstoppableMango

@UnstoppableMango UnstoppableMango commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

unmango/containers ends each of its two workflows in a summary job that needs the rest of that workflow's jobs:

Workflow Summary context Gates
CI build check (<system>) ×3, manifests
Images image enumerate, image (<image>, <arch>) ×10

The real work runs in matrices, which report a context per leg. A ruleset cannot require those without naming every system and every image, so it would need editing here each time an image is added. The summary jobs give two stable names instead.

build was already required, so this only adds image — which is the one that actually gates building every image on both architectures.

Verified

pulumi preview --diff against prod:

    ~ github:index/repositoryRuleset:RepositoryRuleset: (update)
      ~ rules: { ~ requiredStatusChecks: { ~ requiredChecks: [
              + [1]: { + context: "image"  + integrationId: 15368 }
      ] } }

Resources:
    ~ 1 to update
    92 unchanged

dprint check and make lint pass.

Context: unmango/containers#1.

Summary by CodeRabbit

  • Chores

    • Updated repository validation requirements so both build and image checks must pass before changes are accepted.
    • Improved workflow status reporting for matrix-based build and image processes.
  • Documentation

    • Added guidance explaining the workflow summary checks and how they represent matrix-based CI and image workflows.

Copilot AI lite review requested due to automatic review settings September 5, 2026 20:30
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1048c0ba-21ff-43d2-a087-98ec7c017fb0

📥 Commits

Reviewing files that changed from the base of the PR and between ca459fe and 28f85c9.

📒 Files selected for processing (1)
  • index.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The containers repository configuration now requires both build and image summary checks for matrix-based CI and image workflows.

Changes

Containers check requirements

Layer / File(s) Summary
Repository check requirements
index.ts
The configuration requires build and image summary checks. Comments document their roles in matrix-based workflows.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 28f85

The containers repository will require the image summary check in addition to build, ensuring matrix image results gate merges. No merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: requiring the image check for the containers repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-containers-checks

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The required status check contexts now align with the actual GitHub Actions job names and the change is narrowly scoped to ruleset configuration.

Pull request overview

Updates the GitHub ruleset configuration for the unmango/containers repository so required status checks match the actual GitHub Actions job names produced by CI, preventing PRs from being blocked by a non-existent build context.

Changes:

  • Replace the single required check build with the per-system matrix job contexts (build (x86_64-linux), build (aarch64-linux), build (aarch64-darwin)).
  • Add manifests and enumerate as additional required checks to align with the repo’s CI/workflow coverage.
File summaries
File Description
index.ts Updates containers repo githubChecks to require the correct matrix job contexts and add manifests/enumerate.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pulumi

pulumi Bot commented Sep 5, 2026

Copy link
Copy Markdown

🍹 The Update (preview) for UnstoppableMango/unmango-github/prod (at 28f85c9) was successful.

Resource Changes

    Name        Type                                              Operation
~   containers  github:index/repositoryRuleset:RepositoryRuleset  update

@UnstoppableMango UnstoppableMango changed the title fix: correct required status checks for containers docs: explain the single required check for containers Sep 5, 2026
unmango/containers ends each workflow in a summary job that needs the rest of
its own jobs: `build` for CI, `image` for Images. The real work runs in
matrices over systems and images, which report a status context per leg and
cannot be required here without naming every one.

`build` was already required, so this adds `image`, which gates building every
image on both architectures.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@UnstoppableMango UnstoppableMango changed the title docs: explain the single required check for containers fix: require the image check for containers Sep 5, 2026
@UnstoppableMango
UnstoppableMango merged commit f2de2b5 into main Sep 5, 2026
4 checks passed
@UnstoppableMango
UnstoppableMango deleted the fix-containers-checks branch September 5, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants