Remove dead Travis CI and Code Climate references - #604
Open
tas50 wants to merge 1 commit into
Open
Conversation
Neither service has run against this project in years. Code Climate was acquired and codeclimate.com/github/upserve/docker-api now 301s to qlty.sh, which serves an HTML login page rather than an SVG. The README badge therefore renders as a broken image. Travis has not been used since GitHub Actions was added in Feb 2021 (535a59e). The leftover .travis.yml is stale in every dimension: Ruby 2.2-2.7, Docker 18.06/18.09/19.03, Ubuntu bionic, and bundler ~> 1.17.3. - Delete .travis.yml. - Delete script/install_docker.sh. Its only caller was .travis.yml; the GitHub Actions workflow inlines its own Docker install steps. - Remove the broken Code Climate badge from the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither service has run against this project in years.
Code Climate was acquired, and
codeclimate.com/github/upserve/docker-apinow 301s toqlty.sh, which serves an HTML login page rather than an SVG. The README badge therefore renders as a broken image.Travis has not been used since GitHub Actions was added in Feb 2021 (535a59e). The leftover
.travis.ymlis stale in every dimension: Ruby 2.2-2.7, Docker 18.06/18.09/19.03, Ubuntu bionic, and bundler~> 1.17.3.Changes
.travis.yml.script/install_docker.sh— its only caller was.travis.yml, and the GitHub Actions workflow inlines its own Docker install steps.No CI configuration is affected:
.github/workflows/unit_test.ymlis untouched and remains the only thing running tests.Out of scope
script/docker(SysV init script) andscript/docker.conf(upstart config) are also unreferenced dead code, last touched in 2016 for Docker 1.6. They are not Travis-specific, so I left them alone — happy to remove them in a follow-up if you would like.