fix(completion): return suggestions instead of the help page

[vrobert78]

Problem

Tab completion returns nothing in zsh, bash and fish, out of the box and via eval "$(upsun completion)". The completion function is registered correctly; the request it makes comes back empty.

The generated scripts fetch suggestions from the hidden _complete command of the legacy CLI, passing the shell as a glued short option:

_complete --no-interaction -szsh  -a1 -c$((CURRENT-1)) ...   # zsh
_complete --no-interaction -sbash -c$cword -a1 ...           # bash
_complete --no-interaction -sfish -a1 ...                    # fish

The Go layer parses these with Cobra before handing them to the legacy CLI. Cobra's root command uses FParseErrWhitelist{UnknownFlags: true}, which makes pflag walk a glued short option letter by letter (-s, -z, -s, -h). Every supported shell name contains an h, so the bundle always ends with -h, and the root help function rewrites the invocation as help _complete …:

$ upsun _complete --no-interaction -szsh -c1 -iupsun -ienv
Command: _complete
Description: Internal command to provide shell completion suggestions
...                              # <- help page, not completions

The completion function silently discards that. The legacy PHP CLI parses the glued form correctly on its own (php legacy/bin/platform _complete … -szsh returns suggestions), so the Go layer was the only thing at fault.

The same applies to the input tokens the scripts pass, which is why fixing only the templates is not enough: completing upsun ssh --pro<TAB> sends -issh, and that h gets bundled in too.

Fix

• Proxy _complete through a hidden Cobra command with DisableFlagParsing, so completion requests reach the legacy CLI unchanged. This also repairs completion files users already have installed, and covers input tokens containing an h.
• Emit --shell=<shell> in the generated scripts, so a request no longer depends on how glued short options are parsed.
• Skip the update check and the shell-config-leftovers notice for completion requests: they run on every Tab, and the bash script captures stderr along with stdout, so any message would land in the suggestion list.

Verification

Real Tab presses driven through a pty in zsh, bash and fish (Debian container, plus zsh on macOS), for each install method — 27/27 pass with the fix, and the table below shows why the template change alone would not have been sufficient:

binary + installed script	upsun env⇥	… --for⇥	upsun ssh --pro⇥
fixed + newly generated script	✅	✅	✅
fixed + previously installed (glued) script	✅	✅	✅
fixed + eval "$(upsun completion)"	✅	✅	✅
before + long-option script (templates only)	✅	✅	❌
before + its own script (status quo)	❌	❌	❌

OEM (vendorized) CLIs

Same bug, same fix. Verified with the Akeneo Extension Platform CLI, installed in a container with its own installer (curl -fsSL https://cli.extension.akeneo.cloud/installer | sh), which downloads the standard upsun release binary and points it at the vendor config.yaml through a wrapper script:

configuration	env⇥	… --for⇥	ssh --pro⇥
released binary 5.10.8, as installed by the vendor installer	❌	❌	❌
fixed binary swapped in, newly generated script	✅	✅	✅
fixed binary, previously installed (glued) script	✅	✅	✅
-tags vendor build with the Akeneo config embedded	✅	✅	✅

Identical results in zsh, bash and fish for every row above. OEM users get the fix through the normal release, since the installer pulls the standard release binary.

Tests added: commands/completion_test.go (script rewrite, and completion arguments reaching the command unparsed) and integration-tests/completion_test.go (generated scripts, and a real _complete request in short form, long form, and with an input token containing an h). All fail on main and pass here.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR fixes shell tab-completion for the Upsun CLI by preventing Cobra/pflag from mis-parsing legacy _complete requests (notably the glued -s<shell> form that previously produced a bundled -h and triggered help output instead of suggestions). It does so by proxying _complete through a hidden Cobra command with flag parsing disabled, updating generated completion scripts to use --shell=<shell>, and adding regression coverage via unit + integration tests.

Changes:

• Add a hidden _complete Cobra command with DisableFlagParsing to pass completion arguments through to the legacy CLI unchanged.
• Rewrite generated completion scripts to emit --shell=<shell> instead of -s<shell>.
• Skip update checks and shell-config-leftovers notices for completion requests; add unit and integration tests to cover both short/long forms.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
commands/root.go	Skips pre/post-run update/notice behaviors for completion requests; registers the new hidden _complete proxy command.
commands/completion.go	Rewrites generated completion scripts’ shell option; implements the hidden _complete proxy and completion-request detection.
commands/completion_test.go	Unit tests for script shell-option rewriting and for ensuring _complete args reach the command unparsed.
integration-tests/completion_test.go	Integration tests validating generated scripts and end-to-end _complete suggestion output for short/long option forms.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[upsun-dispatch]

Note

Reviewed — No blocking findings · 🔵 1 minor point · ⚪ 2 nitpicks

🔍 Full review · 4 files reviewed

🔍 What this review checked

• With DisableFlagParsing, cobra passes a (args after removing only the _complete token) to Run, so -szsh and input tokens such as -issh reach the legacy CLI verbatim.
• isCompletionRequest matches the executed subcommand's Name(), and only the root defines PersistentPreRun/PersistentPostRun, so both guards fire for _complete and for cobra's __complete.
• Skipping PersistentPreRun means the update-check goroutine is never started, so the skipped select in PersistentPostRun leaves nothing blocked or leaked.
• --shell=<shell> is the long form of Symfony's _complete -s option and contains no bundled -h, so newly generated scripts also work against older binaries via the root fallthrough.
• The shell-option rewrite runs after the phar-path/basename→executable substitution, so the two replacements cannot interfere.

Verification. Covered by the new commands/completion_test.go (run by the test CI job via make test) and integration-tests/completion_test.go (run by the integration-test job, which builds platform.phar and the binary before make integration-test); no automated test drives a real shell, so the pty matrix in the description is manual only, and the stderr-passthrough behaviour of the _complete proxy is untested.

Review details

• Commit: 2e8c151
• Model: claude-opus-5

🔵 Minor point

• commands/completion.go:85 — The _complete proxy wires the legacy child's stderr to cmd.ErrOrStderr() (the real stderr). Symfony's bash completion script runs the request as sfcomplete=$("${completecmd[@]}" 2>&1) and uses the captured text as the suggestion list whenever the exit status is 0 — which is exactly the reasoning given for exitSilently. So any line the legacy CLI (or PHP itself, e.g. a deprecation notice or a TLS/cert warning) writes to stderr while still exiting 0 is offered to the user as a completion candidate. Redirecting the child's stderr to io.Discard for this command (or buffering it and only emitting it under --debug) closes the same hole the exit path already guards.

---

⚪ Nitpicks

• commands/completion.go:24 — shellOptionReplacer is a literal allowlist of -szsh, -sbash and -sfish. Symfony's completion command dumps one template per supported shell, so a script generated for any other shell it supports keeps the glued short form and depends entirely on the new _complete proxy for correctness; the integration test's NotContains("-s"+shell) assertion likewise only covers these three. Deriving the replacement from the requested shell argument (or rewriting -s<name> generically) would keep the template fix in step with the legacy CLI.
• commands/completion.go:78 — Registering _complete as a Cobra command changes upsun help _complete: newHelpCommand resolves it via cmd.Root().Find (Hidden does not exclude it) and the root help func then prints the Cobra usage stub, instead of delegating to the legacy CLI's own _complete help as before. Harmless for an internal command, but it is a behaviour change worth knowing about.

---

Review 1 of 10 for this pull request · View the full run