fix(bugs): clamp page on empty client-side filter results

[ayush-that]

bugs list --vulns --page 5 on a repo with no vulns prints Page: 5 of 1.

The issue suggests clamping in both early-return branches. I dropped the returns instead: they only printed the empty-result hint, and the code just below already handles an empty set and clamps the page. Now reads Page: 1 of 1.

Closes #334.

---

---

Summary by cubic

Clamps page number for empty client-side filter results in bugs list, fixing incorrect "Page: N of 1" output. Before: early returns printed the hint and returned "Page: 5 of 1"; now: print the hint (table only) and fall through to normal pagination, yielding "Page: 1 of 1".

• Removes two early returns in empty-result branches; retains the empty-results hint for table output.
• Delegates empty sets to output_list, which clamps the page.
• No changes to non-table formats or non-empty results.

^{Written for commit 4b3aa46. Summary will update on new commits.}

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

[cubic-dev-ai]

No issues found across 1 file

_{Re-trigger cubic}

[devin-ai-integration]

Tested this PR end-to-end by running the locally built binary against a locally running Detail backend (dev DB) with a minted API key. All scenarios pass; the page clamp now applies on empty client-side filter results.

Baseline (main) vs fix (this PR) — repo bkRoad (bugs but zero vulns):

$ detail bugs list bkRoad --vulns --page 5        # main (broken)
No security vulnerabilities found with the current filters.

Page: 5 of 1

$ detail bugs list bkRoad --vulns --page 5        # this PR (fixed)
No security vulnerabilities found with the current filters.

Page: 1 of 1

Other scenarios (all passed)

--introduced-by with a nonexistent author, --page 7:

No bugs matched --introduced-by. None of the current bugs have author information.

Page: 1 of 1

JSON format on empty results (no hint, valid JSON, clamped page):

$ detail bugs list bkRoad --vulns --page 5 --format json
{ "items": [], "total": 0, "page": 1, "total_pages": 1 }

Regression — non-empty results unchanged (detail repo, 205 pending bugs / 11 vulns):

• bugs list detail --page 2 → 50 entries numbered 51–100, footer Page: 2 of 5
• bugs list detail --vulns → 11 vuln bugs, footer Page: 1 of 1, no hint

Also verified locally: cargo build, cargo clippy -- -D warnings, cargo fmt --check, cargo test (all pass).

Written by Devin

[devin-ai-integration]

/aviator merge

[aviator-app]

Aviator has accepted the merge request. It will enter the queue when all of the required status checks have passed. Aviator will update the sticky status comment as the pull request moves through the queue.

[devin-ai-integration]

Approving after end-to-end testing (see test results comment above). Approved on behalf of Sachin's merge request.

[sachiniyer]

thanks for the contribution @ayush-that !

[aviator-app]

Skipping bot pull request creation because the queue is empty and this pull request is up to date with main.

[aviator-app]

This pull request failed to merge: blocked by Github, possibly missing approvals or merge cannot be cleanly created. After you have resolved the problem, you should remove the blocked pull request label from this PR and then try to re-queue the PR.

Failed checks: Security Audit, Vendored Artifacts, Tests, Check, Clippy, plan, Formatting

Additional debug info: Merge commits are not allowed on this repository.